Improved guide to testing/contributing #2537
Conversation
|
Heads up: |
|
Which port did you use? On Friday, August 14, 2015, Nathan Hammond notifications@github.com wrote:
|
README.md
Outdated
There was a problem hiding this comment.
I shouldn't have committed this change. There is nothing different compared
to before.
I initially thought about altering the Mac installation description for
Lamp, because PHP was already installed on OS X.
Then I thought it would be better just to insert a quick tip for using PHPs
build server if you're on OS X or already have OS X installed.
Because maybe some people still want to use LAMP on OS X.
On Monday, August 17, 2015, Michał Gołębiowski notifications@github.com
wrote:
In README.md
#2537 (comment):
- Linux: Setting up LAMP
- Mongoose (most platforms)
+- Mac: MAMP downloadWhy this change?
—
Reply to this email directly or view it on GitHub
https://github.com/jquery/jquery/pull/2537/files#r37152489.
There was a problem hiding this comment.
I'm not sure we still recommend to use those, for Windows, sure, but for the Linux or Mac? If it is a Linux user, their definitely know how to install php and http-server. If it is a Mac user, their already have apache and php in the system.
There was a problem hiding this comment.
They still need to be configured, even on a Mac and it's not that easy.
The best solution would be to fix #1755 but it needs some effort.
|
@riichard Did you see our comments? The standalone PHP server won't work and the Mac info was just swapped so these changes should be reverted. This will get README.md back to the state it was in, the only change will be in CONTRIBUTING.md. Would you like to apply these changes? Or do you have any other suggestions? |
|
@mzgol I see your comments, the tests worked fine with php running on my machine but I guess there are exceptions and differences to apache. It's best to leave that README.md suggestion out then. I would still like to apply the changes to CONTRIBUTING.md. |
Did you run the whole suite? I remember I used to have a lot of issues with the standalone server, although now I see only 4 of them (I tried on OS X 10.11 GM Candidate, PHP 5.5.27): If my memory is fine, though, it might work worse on older versions and even then the test suite still doesn't pass completely. So I think this advice would be risky in general.
Sure. :) Just revert the other changes and we'll land this one. |
|
It was a challenge for me to revert that commit from github, but I got it done. The PHP server suggestion commit is removed. The only commit left fixes CONTRIBUTING.md's missing 'npm run build' step. |
|
LGTM. |
|
LGTM |
6 participants
npm buildstep when setting up the repository.