Core: Don't expose jQuery.access #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery.access was never documented, there is no need to keep it exposed. Fixes jquerygh-2513 Closes jquerygh-2524
Member
Author
|
Because of how trivial it is I'd like to land it tomorrow. |
Member
|
Yeah, pretty trivial so no problem assuming nobody is using it externally. It's not used in Migrate, the only place I might fear we'd use it. |
Member
Author
|
I wanted to land it now but swarm is down. :( |
Member
Author
|
Landed (swarm is OK again). |
riichard
pushed a commit
to riichard/jquery
that referenced
this pull request
Sep 20, 2015
jQuery.access was never documented, there is no need to keep it exposed. Fixes jquerygh-2513 Closes jquerygh-2524
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery.access was never documented, there is no need to keep it exposed.
Fixes gh-2513