Skip to content

Conversation

@markelog
Copy link
Member

@FagnerMartinsBrack hope you will be happy about this :-).

Did it with CST script manipulation - https://github.com/markelog/qunit-migration/blob/master/src/migration.js

@scottgonzalez, @jzaefferer, @Krinkle
I suppose it would be useful if qunit would provide scripts like that, here it only replaces deprecated argument, but it could do a lot more.

@nzakas i guess this could be another example of manipulation with CST.

@FagnerMartinsBrack
Copy link

@FagnerMartinsBrack hope you will be happy about this :-).

I won't be "happy", just thought it would be useful reminding about it ;)

@jzaefferer
Copy link
Member

There's a similar tool for migrating to the QUnit 2.0 API, though using regex replace: https://github.com/apsdehal/qunit-migrate

Surely would be good to have one reliable tool that handles the full migration.

@markelog
Copy link
Member Author

@FagnerMartinsBrack

just thought it would be useful reminding about it ¬¬

It totally was! Your remainder prompt me to do this

@jzaefferer

There's a similar tool for migrating to the QUnit 2.0 API

That sounds cool, although regexs aren't, it seems though, it missing this kind of manipulation.

@dmethvin
Copy link
Member

This LGTM. It would be convenient if QUnit.config.requireExpect let you require only the expect() format instead of the function arg, but I doubt this will be a problem in future tests since people tend to copy whatever style is nearby.

@mgol
Copy link
Member

mgol commented Jul 30, 2015 via email

@markelog markelog closed this in aabe94e Jul 30, 2015
@markelog
Copy link
Member Author

At the weekend i will try to apply manipulation from the module that @jzaefferer mentioned

riichard pushed a commit to riichard/jquery that referenced this pull request Sep 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants