Skip to content

Conversation

@bperel
Copy link
Contributor

@bperel bperel commented Jul 21, 2015

No description provided.

@arthurvr
Copy link
Member

You shouldn't create a new PR to update it, you can just update the existing one ;)

The changes here look good, but you'll need to sign the CLA.

@bperel
Copy link
Contributor Author

bperel commented Jul 21, 2015

I have signed the CLA but although my email address and name match my Git config the "CLA Verification Results" page says "The following authors don't have appropriate CLA signatures", followed with my info. Is there a delay after someone sends the CLA form ?

@mgol
Copy link
Member

mgol commented Jul 21, 2015

The signature looks OK to me. @scottgonzalez, any idea why the check fails?

@scottgonzalez
Copy link
Member

The signature looks OK to me. @scottgonzalez, any idea why the check fails?

The first signature for the CLA is "Bruno Pérel" which doesn't match because the accent is not present in the commit name.

@bperel
Copy link
Contributor Author

bperel commented Jul 30, 2015

Thanks @scottgonzalez , should be good now :)

@arthurvr
Copy link
Member

Thanks @bperel :) Looks good to me.

@mgol mgol closed this in 360a478 Jul 30, 2015
mgol pushed a commit that referenced this pull request Jul 30, 2015
@mgol
Copy link
Member

mgol commented Jul 30, 2015

@bperel Thx, landed.

riichard pushed a commit to riichard/jquery that referenced this pull request Sep 20, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants