Added $.uniqueSort for selector-native. #2467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've sent CLA after sending this PR. Will bot update the label correctly? |
Member
|
As long as you signed with the same name and email as the commit it should be fine. If new commits are pushed to this PR it will do the check again, so hold on and let's see if any are needed. Great catch by the way! |
src/selector-native.js
Outdated
Member
There was a problem hiding this comment.
Since the "method" is actually context-free, I'd rather not introduce a reliance upon this. jQuery.unique = jQuery.uniqueSort or var uniqueSort = function …; jQuery.extend({ …, unique: uniqueSort, uniqueSort: uniqueSort, … }) would be better. Other than that, though, LGTM!
Contributor
Author
|
Is there anything more I can do for this PR? |
Member
|
Nope; we're all set. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see that some time ago in e1090c3 there was a change where you started using jQuery.uniqueSort rather than jQuery.unique.
This change was not reflected in
selector-native.jsfile, thus exception reported in #2466.