Skip to content

Conversation

@mixed
Copy link
Contributor

@mixed mixed commented Jun 25, 2015

I removed unnecessary parameter for constructor of "end" method. It`s because jQuery constructor with no parameter is the same as jQuery constructor with null parameter.

Review on Reviewable

@mixed mixed changed the title Core:Removed unnecessary parameter Core:Suggest remove unnecessary parameter Jun 25, 2015
@mgol
Copy link
Member

mgol commented Jun 25, 2015

LGTM, especially that the jQuery() signature is documented at http://api.jquery.com/jQuery/ and jQuery( null ) is not.

Could you sign our CLA? This is why the build fails.

@mgol mgol self-assigned this Jun 25, 2015
@mgol mgol added this to the 3.0.0 milestone Jun 25, 2015
@mixed
Copy link
Contributor Author

mixed commented Jun 26, 2015

@mzgol
Thank you. I singed CLA just. :)

@mgol
Copy link
Member

mgol commented Jul 1, 2015

@mixed You need to sign the CLA with your full name; the commit needs to have your full name as an author as well (it'd be best if you modified your Git config so that this problem doesn't happen in the future).

@mixed
Copy link
Contributor Author

mixed commented Jul 2, 2015

OK. Again PR. :)

@mixed mixed closed this Jul 2, 2015
@mixed mixed deleted the removeParam branch July 2, 2015 06:16
@mgol
Copy link
Member

mgol commented Jul 2, 2015

You didn't need to close the PR; it was enough to amend the commit & change the author info & then "git push --force" to the branch. In this way we'd have the whole discussion contained in one place, not spread accross multiple attempts.

@mixed
Copy link
Contributor Author

mixed commented Jul 2, 2015

@mzgol
I'm sorry... My mistake. I am not comfortable "github". I found this way. but I send PR(#2441) already.
I changed name and email. but I unsinged CLA still. Is it my problem?
#2441 (comment)

@mgol mgol removed this from the 3.0.0 milestone Mar 6, 2016
@mgol
Copy link
Member

mgol commented Mar 6, 2016

This issue was duplicated in #2441 so I removed the milestone from this one.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants