Skip to content

Build: space between curly and paren is optional #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timmywil wants to merge 1 commit into from
Closed

Build: space between curly and paren is optional #2400

timmywil wants to merge 1 commit into from

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Jun 16, 2015

Fixes gh-2399

mgol
mgol reviewed Jun 16, 2015
View reviewed changes
build/tasks/build.js
Copy link
Member

@mgol mgol Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very minor nit: the non-greediness doesn't matter here as \) doesn't match \s anyway, other regexps in this file don't use it.

Copy link
Member Author

@timmywil timmywil Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally use non-greedy unless I explicitly want greediness.

Copy link
Member

@mgol mgol Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, doesn't matter.

@mgol
Copy link
Member

mgol commented Jun 16, 2015

LGTM.

@timmywil timmywil closed this in 63a577a Jun 19, 2015
@timmywil timmywil deleted the 2399-build branch June 19, 2015 17:41
markelog pushed a commit to markelog/jquery that referenced this pull request Sep 3, 2015
@timmywil @markelog
Build: space between curly and paren is optional
5ae0c1e 
Ref 63a577a
Fixes jquerygh-2399
Close jquerygh-2400
markelog pushed a commit to markelog/jquery that referenced this pull request Sep 3, 2015
@timmywil @markelog
Build: space between curly and paren is optional
6a6e90d 
Ref 63a577a
Fixes jquerygh-2399
Close jquerygh-2400
markelog pushed a commit to markelog/jquery that referenced this pull request Sep 3, 2015
@timmywil @markelog
Build: space between curly and paren is optional
5fbb931 
Ref 63a577a
Fixes jquerygh-2399
Close jquerygh-2400
timmywil added a commit that referenced this pull request Sep 7, 2015
@timmywil @markelog
Build: space between curly and paren is optional
cbb0be6 
Ref 63a577a
Fixes gh-2399
Close gh-2400
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timmywil @mgol @jquerybot