Skip to content

Offset: return zeros for disconnected elements and allow setting #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timmywil wants to merge 2 commits into from
Closed

Offset: return zeros for disconnected elements and allow setting #2396

timmywil wants to merge 2 commits into from

Conversation

@timmywil
Copy link
Member

@timmywil timmywil commented Jun 15, 2015

Fixes gh-2310

gibson042
gibson042 reviewed Jun 15, 2015
View reviewed changes
test/unit/core.js
Copy link
Member

@gibson042 gibson042 Jun 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member Author

@timmywil timmywil Jun 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was from the revert commit. The whole file needs adjustments, so it's not really worth changing that one line back.

@timmywil timmywil closed this in 40dcc76 Jun 16, 2015
timmywil added a commit that referenced this pull request Jun 16, 2015
@timmywil
Offset: return zeros for disconnected/hidden elements
63f19a9 
Fixes gh-2310
Close gh-2396
@timmywil timmywil deleted the 2310-offset branch June 16, 2015 14:57
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timmywil @gibson042 @jquerybot