Remove internal args to on & remove methods #2366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice 👍 |
Member
|
I wonder if it would gzip better if we did |
Member
Author
In |
Member
|
👍 thanks for doing this. |
Member
Author
|
I'll land this shortly barring any new remarks. |
src/manipulation.js
Outdated
Member
There was a problem hiding this comment.
There's small savings (4 btyes min+gzip) to defining detach immediately before remove and moving both of them to the top of the jQuery.fn.extend block, but that's about it. I'm in favor of this.
Member
Author
There was a problem hiding this comment.
Currently it's only -3 bytes but I'll do it.
mgol
force-pushed
the
remove-internal-args
branch
from
ea6c1b5 to
2aa6942
Compare
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Jun 13, 2015
mgol
force-pushed
the
remove-internal-args
branch
from
2aa6942 to
349edbd
Compare
mgol
added a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-2301
+24 bytes, most of which come from event changes. The manipulation change adds just 5 bytes.
I've also tried to move
onto a proper/var/directory but it only increased the size further.Any ideas on how to reduce the size increase?