Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented May 30, 2015

Refs 0705be4
Refs gh-2287

cc @markelog

@markelog
Copy link
Member

How did you find this?

@mgol
Copy link
Member Author

mgol commented May 30, 2015

I just reminded myself that we had this duplicate logic and that I didn't see it removed in your PR so I found it. :)

@mgol
Copy link
Member Author

mgol commented May 30, 2015

Hmm, I guess the "../event/alias" dependency can be removed as well?

@markelog
Copy link
Member

markelog commented Jun 1, 2015

I just reminded myself that we had this duplicate logic

After a week it was landed? Your memory is an interesting thing :-)

@mgol
Copy link
Member Author

mgol commented Jun 1, 2015

After a week it was landed? Your memory is an interesting thing :-)

Actually, it was because jsFiddle broke on Git jQuery as they used the .load() shortcut and I searched for your commit to present it to them as the reason. And then it hit me when I looked at the diff. :)

@mgol mgol closed this in 38a6697 Jun 1, 2015
@mgol mgol deleted the old-load branch June 1, 2015 17:06
mgol added a commit that referenced this pull request Jun 1, 2015
@markelog
Copy link
Member

markelog commented Jun 1, 2015

Actually, it was because jsFiddle broke on Git jQuery as they used the .load() shortcut and I searched for your commit to present it to them as the reason. And then it hit me when I looked at the diff. :)

❤️ 😡 both emotions there, we really need some tests for that kind of thing, i'd say we really need a code coverage tool here.

/cc @timmywil

@timmywil
Copy link
Member

timmywil commented Jun 2, 2015

Yup, it's on the list! #1965

@markelog markelog mentioned this pull request Nov 16, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants