-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Tests: Change quotes according to style guidelines #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems we can /cc @timmywil |
|
Sure! Are they not used? |
|
As i see, they not used in testsuite, it looks like their useful only if you open them manually, but honestly, i didn't even know we had them. |
|
What about moving them to an |
|
Note that |
Would still need to rewrite them, for example, there is page that uses |
|
Good point, but, like I said, we can save the rewrites/removals for later.
|
|
So @lexinerus would like to do that? Make sure those tests are still relevant and if they are, rewrite them and move to |
|
The CLA check is fine now. |
|
We don't run these tests very often. I don't think we need the reminder On Sun, Aug 16, 2015 at 8:06 PM Michał Gołębiowski notifications@github.com
|
|
I guess we need a .md doc for the release procedure (or we already have one?). Since we doing more then just running one command |
|
|
Ah, thanks, okay so we would need to add another item there when we deal with update these tests |
|
Item added. |
Modifies the quotes in the test files according to the style guidelines explained here: http://contribute.jquery.org/style-guide/js/#quotes