Skip to content

Conversation

@64lines
Copy link
Contributor

@64lines 64lines commented May 21, 2015

Modifies the quotes in the test files according to the style guidelines explained here: http://contribute.jquery.org/style-guide/js/#quotes

@markelog
Copy link
Member

It seems we can rm those files.

/cc @timmywil

@timmywil
Copy link
Member

Sure! Are they not used?

@markelog
Copy link
Member

As i see, they not used in testsuite, it looks like their useful only if you open them manually, but honestly, i didn't even know we had them.

@timmywil
Copy link
Member

timmywil commented Jun 1, 2015

What about moving them to an integration folder? Eventually, we can automate running all pages in that folder using something like webdriver. The tests would still need adjustment, but we can get to that later.

@mgol
Copy link
Member

mgol commented Jun 1, 2015

Note that compat already has the test/integration directory, currently containing just one test: https://github.com/jquery/jquery/tree/42ea7468250f1b612684a71b8643ae25367ff469/test/integration

@markelog
Copy link
Member

markelog commented Jun 1, 2015

What about moving them to an integration folder?

Would still need to rewrite them, for example, there is page that uses live() in there. I'm not sure what kind of behaviour is tested on those pages.

@timmywil
Copy link
Member

timmywil commented Jun 2, 2015

Good point, but, like I said, we can save the rewrites/removals for later.
On Mon, Jun 1, 2015 at 18:43 Oleg Gaidarenko notifications@github.com
wrote:

What about moving them to an integration folder?

Would still need to rewrite them, for example, there is page that uses
live() in there. I'm not sure what we support in there.


Reply to this email directly or view it on GitHub
#2339 (comment).

@markelog
Copy link
Member

So @lexinerus would like to do that? Make sure those tests are still relevant and if they are, rewrite them and move to integration folder?

@jzaefferer
Copy link
Member

The CLA check is fine now.

@mgol
Copy link
Member

mgol commented Aug 17, 2015

@markelog @timmywil I'd rather not have files not working with current jQuery in the integration folder. Perhaps in integration/old or integration/legacy, or integration/to-rewrite so that it's clear they're not expected to work currently?

@timmywil
Copy link
Member

We don't run these tests very often. I don't think we need the reminder
with a folder name, just with an issue that tells us to rewrite these tests
and run them before final release.

On Sun, Aug 16, 2015 at 8:06 PM Michał Gołębiowski notifications@github.com
wrote:

@markelog https://github.com/markelog @timmywil
https://github.com/timmywil I'd rather not have files not working with
current jQuery in the integration folder. Perhaps in integration/old or
integration/legacy, or integration/to-rewrite so that it's clear they're
not expected to work currently?


Reply to this email directly or view it on GitHub
#2339 (comment).

@markelog
Copy link
Member

I guess we need a .md doc for the release procedure (or we already have one?). Since we doing more then just running one command

@mgol
Copy link
Member

mgol commented Aug 17, 2015

I guess we need a .md doc for the release procedure (or we already have one?). Since we doing more then just running one command

https://github.com/jquery/jquery/wiki/Release-process

@markelog
Copy link
Member

Ah, thanks, okay so we would need to add another item there when we deal with update these tests

@timmywil
Copy link
Member

Item added.

@mgol mgol added the Needs info label Sep 7, 2015
@timmywil timmywil closed this in c577928 Oct 18, 2015
gibson042 pushed a commit that referenced this pull request Oct 25, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

6 participants