Skip to content

Conversation

@pgilad
Copy link
Contributor

@pgilad pgilad commented May 19, 2015

specifying the type and URL is deprecated:

https://docs.npmjs.com/files/package.json#license
http://npm1k.org/

@mgol
Copy link
Member

mgol commented May 19, 2015

LGTM; this fixes #2331.

@mgol
Copy link
Member

mgol commented May 19, 2015

@pgilad could you sign our CLA and add Fixes gh-2331 to the commit message?

@pgilad
Copy link
Contributor Author

pgilad commented May 19, 2015

Signed and fixed commit message

@mgol
Copy link
Member

mgol commented May 19, 2015

Thanks. I'd wait with merging for a moment until the discussion at npm/npm#4473 settles.

@mgol mgol self-assigned this May 19, 2015
@rlidwka
Copy link

rlidwka commented May 20, 2015

I'd wait with merging for a moment until the discussion at npm/npm#4473 settles.

Well, the issue got locked with no good resolution (only a proposal to include license data to couchdb in npm/npm#4473 (comment)).

Until that happens, personally, I'm going to use a deprecated format in my packages (prefer WTFPL license which npm website used to point to nowhere without an explicit link). Just tested, npm displays warning during development only, and won't affect users installing a package. So I guess ignoring it would be fine.

@timmywil
Copy link
Member

timmywil commented Jun 1, 2015

@scottgonzalez What's your take on this? If we make this change, we should probably change it in all jQuery projects.

@scottgonzalez
Copy link
Member

I'm not a fan of the change, but there's no point in fighting it since npm isn't going to reverse this decision. I've filed https://github.com/npm/newww/issues/985 to get the proper links on the npm site. We should update all projects to conform to the new package.json spec.

@mgol
Copy link
Member

mgol commented Jun 1, 2015

OK, I'm merging it then.

@mgol mgol closed this in 8e92e1e Jun 1, 2015
mgol pushed a commit that referenced this pull request Jun 1, 2015
@mgol
Copy link
Member

mgol commented Jun 1, 2015

Landed; thanks @pgilad!

@pgilad
Copy link
Contributor Author

pgilad commented Jun 1, 2015

👏

@pgilad pgilad deleted the patch-1 branch June 1, 2015 17:37
markelog pushed a commit that referenced this pull request Nov 10, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants