Event: provide verbose comment for focus(in | out) & rename support prop #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Everything after "id=number" should be cut off
Member
Author
There was a problem hiding this comment.
Sure, although i would prefer if you would use optative then imperative mood when you suggesting something
Member
Author
There was a problem hiding this comment.
Thank you :-), i appreciated it.
Member
|
It's nice to have more info 👍 |
Member
Author
|
It just took me couple hours to realize that this shim wasn't there to create bubble focus(in | out) events :-) |
Member
|
Anything that helps people understand this mess is a good thing. 👍 |
markelog
added a commit
that referenced
this pull request
May 19, 2015
markelog
added a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.