CSS: fix :visible/:hidden selectors for inline element w/ content #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reverts behavior from 10399dd, which we never released. BR and inline elements are considered visible. - The possibility of dropping .offsetWidth and .offsetHeight was debunked by this perf: http://jsperf.com/visible-hidden-and-getclientrects Fixes jquerygh-2227
Member
|
LGTM |
Member
|
Does it mean we might not be able to use fractional values for .css('width') and friends due to perf reasons? |
Member
|
I don't think so. |
Contributor
There was a problem hiding this comment.
Would it make sense to inline and reverse the logic from jQuery.expr.filters.visible() to save a func call?
Member
Author
There was a problem hiding this comment.
We haven't noticed a perf loss and this way guarantees hidden and visible are opposites.
Member
There was a problem hiding this comment.
The browser probably does that anyway, and even if it does take another function call the DOM queries will be much more cruel.
timmywil
added a commit
that referenced
this pull request
May 12, 2015
- Reverts behavior from 10399dd, which we never released. BR and inline elements are considered visible. - The possibility of dropping .offsetWidth and .offsetHeight was debunked by this perf: http://jsperf.com/visible-hidden-and-getclientrects Fixes gh-2227 Close gh-2281
timmywil
added a commit
that referenced
this pull request
Nov 10, 2015
- Reverts behavior from 10399dd, which we never released. BR and inline elements are considered visible. - The possibility of dropping .offsetWidth and .offsetHeight was debunked by this perf: http://jsperf.com/visible-hidden-and-getclientrects Fixes gh-2227 Close gh-2281
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BR and inline elements are considered visible.
was debunked by this perf:
http://jsperf.com/visible-hidden-and-getclientrects
Fixes gh-2227