Skip to content

CSS: Correct misrepresentation of "auto" horizontal margins as 0 #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gibson042 wants to merge 2 commits into from
Closed

CSS: Correct misrepresentation of "auto" horizontal margins as 0 #2276

gibson042 wants to merge 2 commits into from

Conversation

@gibson042
Copy link
Member

@gibson042 gibson042 commented May 8, 2015

Fixes gh-2237

But as expected, it's pretty big:

   raw     gz Compared to compat @ fb25bacf9b809a08c29e76decd8cda1579fdf192    
  +790   +196 dist/jquery.js                                                   
  +290    +78 dist/jquery.min.js

markelog
markelog reviewed May 11, 2015
View reviewed changes
src/css/support.js
Copy link
Member

@markelog markelog May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, there is no spaces in ranges :-), i.e. Android 4.0-4.3 only

Copy link
Member Author

@gibson042 gibson042 May 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jquery/contribute.jquery.org/issues/95

Copy link
Member

@markelog markelog May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems we didn't had consensus about this issue, it did come down to like/don't like, i'd say we should follow some standart here, if we so nit-picky :-).

http://practicaltypography.com/hyphens-and-dashes.html
http://en.wikipedia.org/wiki/Dash#Ranges_of_values

@markelog
Copy link
Member

markelog commented Oct 8, 2015

If consumer reset style it is Firefox only, right? Should we consider asking ff team to prioritize their ticket you mentioned in affiliated issue instead?

@gibson042
Copy link
Member Author

gibson042 commented Oct 9, 2015

I'm not sure I understand your question... this affects IE8, Android, and Firefox, but I guess it's true that Firefox is the only browser in which the behavior has yet to be fixed.

I probably should have already landed this, but since it's still open, it might as well still be open for discussion.

@markelog
Copy link
Member

markelog commented Oct 9, 2015

I was referencing this discussion.

@timmywil
Copy link
Member

timmywil commented Oct 18, 2015

@gibson042 Is this high enough priority to include in our 1.x release?

gibson042 added a commit that referenced this pull request Oct 18, 2015
@gibson042
CSS: Correct misrepresentation of "auto" horizontal margins as 0
214e163 
Fixes gh-2237
Closes gh-2276
@gibson042 gibson042 closed this in 487d5ca Oct 18, 2015
@dmethvin
Copy link
Member

dmethvin commented Oct 20, 2015

Looks like IE8 started failing when this landed: http://swarm.jquery.org/result/720927

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gibson042 @markelog @timmywil @dmethvin @jquerybot