remove npm from dependencies #2254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/cc @jzaefferer |
Member
|
Fortunately it's only a |
Member
|
I have no idea why I "added" that, certainly wasn't on purpose. |
Member
|
@calvinmetcalf could you sign CLA please? |
Contributor
Author
|
Done On Sun, May 3, 2015, 7:16 AM Oleg Gaidarenko notifications@github.com
|
timmywil
pushed a commit
that referenced
this pull request
May 5, 2015
markelog
pushed a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is unclear why npm was included in the dependencies, it looks like it was accidentally included in this commit 2d5c5d2. I think we can be fairly sure that they will already have npm at this point due to that list being used by npm 😄