Core: Follow the AMD specification for define #2179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderOMara
force-pushed
the
amd-define-spec-fix
branch
from
3396d51 to
72c0cbb
Compare
AMD specification requires the factory argument be defined.
AlexanderOMara
force-pushed
the
amd-define-spec-fix
branch
from
72c0cbb to
ad3015c
Compare
timmywil
pushed a commit
that referenced
this pull request
Apr 13, 2015
AMD specification requires the factory argument be defined. Close gh-2179
markelog
pushed a commit
that referenced
this pull request
Nov 10, 2015
AMD specification requires the factory argument be defined. Close gh-2179
Member
|
This has been backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMD specification requires the factory argument to define.
According to the AMD specification for the
definefunction thefactoryargument is not optional. The RequireJS implementation apparently deviates from the spec by including modules when no factory is specified. In one instance jQuery relies on this non-standard feature which breaks compatibility with spec-compliant AMD loaders. Adding an empty factory function fixes this problem.