Test against the current version of node as well as iojs #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just signed the CLA. |
Member
|
If this PR was submitted half a year ago I'd have said it wasn't necessary
(it's enough to run jsHint in one Node) but we're now smoke testing Node
and we'll soon be testing the Promises/A+ compliance there so it'd be good
to do it in all those versions. So +1 from me.
|
.travis.yml
Outdated
Member
There was a problem hiding this comment.
It'd be better to put it after 0.10 to make the whole list chronological.
Member
|
The commit message should start with a component name, i.e. |
Contributor
Author
|
@mzgol Amended my commit with the component name and changed the order of the node versions |
Closed
timmywil
pushed a commit
that referenced
this pull request
Mar 26, 2015
markelog
pushed a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently travis only tests using node 0.10, so this adds 0.12 and iojs to the travis config.