Make top of the HTML suite compliant with style guide #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markelog
force-pushed
the
html-code-style
branch
from
3760fbd to
c4eda4a
Compare
markelog
changed the title
Member
I think it was that way before I joined! Note that we have #1731 open for a while to figure out how to avoid our XHTML regressions. If we aren't running the tests in XHTML I think it might be good to make it clearer by switching to the HTML5 doctype like you've done here. Then we would need a different main file for an XHTML test. |
Member
Author
|
Yeah, i distinctly remember that issue. |
markelog
added a commit
that referenced
this pull request
Feb 19, 2015
See http://contribute.jquery.org/style-guide/html/ (cherry-picked from 8356281) Closes gh-2098
markelog
added a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make top of the html suite compliant with our html code style.
@dmethvin xhtml doctype was chosen for specific reason or it's fine like that?