Build: Update QUnit to latest (1.17.1) #2038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Member
|
Since nothing changed in Core files, LGTM. We should get the libs copies synced with what's in package.json btw... |
Member
Author
|
Well, I'll leave that exercise to someone who's more familiar with those updated dependencies. |
Member
|
If there is no objections - will land this tomorrow |
Member
|
Hm, this update broke couple traversing and manipulation tests, since new qunit added another form to the test-suite and some of jQuery selectors weren't specific. Will fix that up. |
jzaefferer
added a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
grunt npmcopyalso updated requirejs and sinon. The sinon changes looked like they'd actually break something, so I ignored them both. Can't tell why the dependencies were updated without updating the copies in the repo.