-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Remove deprecated JSHint options #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JSHint no longer supports `onevar`, `smarttabs` or `trailing` options. > JSHint is moving away from purely stylistic warnings. You should use JSCS for that. JSHint's removed options source https://github.com/jshint/jshint/blob/3d9c430259afbecd002ca65662ea3103cae512b8/src/options.js#L875
|
These are indeed deprecated, but removing them would be against our style guide. We recently had a discussion about it here: jquery-archive/css-chassis@24c71e2. |
|
Core uses jshint 2.5, those options no longer there and jscs 1.7.3 where jquery preset have included substitutes for them. @scottgonzalez what is the plan? |
|
This conversation has been had so many times in so many places that I won't even bother trying to track down the actual conversations. Here's the gist of it: We are waiting for @mikesherov to say that JSCS has implemented the right amount of checks before making this a required standard across all projects. Until then, each project is free to do what they want in order to test what works well and what doesn't (so long as their testing doesn't actually regress). Some projects ended up updating JSHint too early, which was bad because they lost the ability to enforce certain style rules. Today, it's safe to use JSCS to catch all the style-related rules that were dropped from JSHint, so it's safe to upgrade both. There is no requirement today other than being able to programmatically enforce the JSHint options listed in the style guide, even if there's a different tool doing that enforcement (such as JSCS + JSHint). |
|
Thanks for the feedback everyone, greatly appreciated. |
Core uses fixed dependency versions but it doesn't help agaisnt auto-update of jshint, since if project uses
I don't understand what is you trying to say, for example, You still want it in the jshint config?
This is not mentioned in the guide, it explicitly said that jshint should do it and such config of jshint should be used. It seems those options should be removed from jshint config and guide should be updated. |
No. If you're using a version of JSHint that doesn't support |
|
Okay, so if understood you correctly - need to wait on guide update (although it still seems weird to have it there) and you're okay with merging this PR and creating new one for chassis? |
Because as of today, JSCS is not a tool that's required across projects. What is required and agreed upon is a set of JSHint settings. We're aiming for common sense here rather than being super pedantic about settings and specific versions of tools. Once we're ready to standardize JSCS, it will be listed in the style guide and the JSHint config will be updated, along with the addition of the JSCS config. |
I'm not sure what you think is weird. You can merge this today, as I've already said. Please ignore Chassis right now, I don't want to get into a discussion about a dozen individual repositories. We have a standard, some projects have opted to test the future implementation by simultaneously using JSCS. Please just stick with what you're doing and when we're ready to change the standard, it will change. |
Guide, currently, ask you to use Guide doesn't say use different tool if those options aren't available in jshint. Currently, guide ask you to follow instructions that are not possible to follow. I think this is weird. If you like, we could move this discussion to the contribute repo. |
|
Had to change two other |
|
👍 Thanks @markelog |
JSHint no longer supports `onevar`, `smarttabs` or `trailing` options. Closes gh-2029
JSHint no longer supports
onevar,smarttabsortrailingoptions (JSHint source here)Bonus: Includes "final new line" based on
.editorconfigrule 😜