Build: Specify valid components for commit messages #1909
Conversation
|
Before we land this, we'll need to ensure the the commits done during the release script don't crap out. I'd be most comfortable if we just disabled it for those commits, nothing would be worse than dying in the middle of a release. @jzaefferer Do commits prefixed with [STUFF] exempt from the component check? The docs weren't clear and I was too lazy to read through the code. /cc @timmywil who has the jquery-release tasks |
|
Looking at build/release.js, you're not doing any custom commits. I've used jquery-release for QUnit's 1.16 release, which includes the commitplease component list. I see no reason why you'd have any issues either. |
|
I think the only commits are for the tag itself, which commitplease has an exception for, the other is prefixed with "Build:", which you're listing here as a valid component. So yes, its fine! |
There was a problem hiding this comment.
What's this one? I think for UI and QUnit we dump release-related commits into "Build".
4 participants
I didn't see a sane place to reference the bypass prefixes (cf. https://github.com/jzaefferer/commitplease#usage ), but they really should be publicized to contributors to prevent unnecessary frustration.
Ref jzaefferer/commitplease#23