Deprecated: Drop size and andSelf methods #1822
Conversation
mgol
changed the title
|
Depracated -> Deprecated |
There was a problem hiding this comment.
If you deleting the file, why not delete the file?
There was a problem hiding this comment.
This serves as a place to dump deprecated stuff in the future. If I remove this file, I need to remove all configuration related to the deprecated module, this will affect what you can pass to the build script etc.
IMO it makes sense only if we don't plan to use this file in the future at all.
I've corrected it almost immediately after submitting this PR. Is there anything left? |
|
That was it from me. The patch itself looked fine. I also noticed the empty module, but based on the current system for custom builds, it seemed fine. Once there's a more visual builder, it won't make sense to show an option for an empty module though. |
|
LGTM as well. Since @mzgol already added patches and warnings for these to jQuery Migrate we're good there as well. We do need a new release of it though. I'd rather keep the empty module in for now, we may decide to move some things into deprecated and it would be a pain to have to put it all back. |
|
@mzgol in the future, if i ask or purpose something, could you wait until my response before going ahead? |
OK. I went ahead because others opted specifically for this way of handling this file. |
(cherry-picked from f110360) Fixes jquerygh-1749 Closes jquerygh-1822
4 participants
Fixes gh-1749