Skip to content

Conversation

@rmcdaniel
Copy link

No description provided.

@rmcdaniel
Copy link
Author

#1708

@dmethvin
Copy link
Member

Note that the Travis build failed since it wasn't run through grunt before the pull request was made. Also there are no unit tests. I believe there are already tests for the offset() method to check these cases, but if we're not handling them we would also need some corresponding unit tests. For more help go to http://contribute.jquery.org.

@rmcdaniel
Copy link
Author

I ran "npm run build" I just didn't notice the errors.

@rmcdaniel
Copy link
Author

I have added some tests.

@dmethvin
Copy link
Member

dmethvin commented Dec 4, 2014

Sorry about the delay, I meant to summon @mikesherov on this to be sure the interpretation was correct.

@timmywil
Copy link
Member

timmywil commented Mar 9, 2015

@mikesherov ping

@timmywil
Copy link
Member

timmywil commented May 5, 2015

@jquery/core Does anyone have an issue with landing this?

@gibson042
Copy link
Member

I'm interested in the size difference between two assignment operations on each parentOffset property vs. one (e.g., parentOffset.top += jQuery.css(…) - offsetParent.scrollTop()), but the logic and test changes look good to me.

@timmywil
Copy link
Member

timmywil commented May 5, 2015

I'm interested in the size difference between two assignment operations on each parentOffset property vs. one (e.g., parentOffset.top += jQuery.css(…) - offsetParent.scrollTop())

It saves 3 bytes.

@timmywil
Copy link
Member

Landing with the proposed change from Richard.

@mgol
Copy link
Member

mgol commented Feb 8, 2016

This PR caused a couple of problems in jQuery 2.2.0 & 1.12.0 so we've reverted it in 49833f7; we'll try to tackle the problem later.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

6 participants