-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Fix #15239: position when parent scrolled #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that the Travis build failed since it wasn't run through |
|
I ran "npm run build" I just didn't notice the errors. |
|
I have added some tests. |
|
Sorry about the delay, I meant to summon @mikesherov on this to be sure the interpretation was correct. |
|
@mikesherov ping |
|
@jquery/core Does anyone have an issue with landing this? |
|
I'm interested in the size difference between two assignment operations on each |
It saves 3 bytes. |
|
Landing with the proposed change from Richard. |
|
This PR caused a couple of problems in jQuery 2.2.0 & 1.12.0 so we've reverted it in 49833f7; we'll try to tackle the problem later. |
No description provided.