Data: avoid non-alphanumeric chars in expando properties #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref chromium issue 378607 Ref jQuery issue 14839
Member
|
/cc @rwaldron, @gibson042 |
Member
|
Ref - we already did the "same" thing for Sizzle. |
Member
|
LGTM |
Member
|
Thank you! |
mgol
pushed a commit
that referenced
this pull request
Dec 11, 2014
Ref chromium issue 378607 Ref #14839 Closes gh-1662
markelog
pushed a commit
that referenced
this pull request
Nov 10, 2015
Ref chromium issue 378607 Ref #14839 Closes gh-1662
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref chromium issue 378607
Ref jQuery issue 14839
As discussed a bit in the original commit (jbedard@ed3a988#commitcomment-7857752) and bug (http://bugs.jquery.com/ticket/14839) this avoids the use of non-alphanumeric characters in the expando property used by the
Dataobjects.This avoids https://code.google.com/p/chromium/issues/detail?id=378607 when creating data on an element for the first time. It seems like jq2 doesn't cleanup the expando property on cleanData so the delete case doesn't occur.