Skip to content

Zombie 2.5.1/JSDom 1.4.0 (last node 0.12 version) and jQuery 1.12 #2806

@justinbmeyer

Description

@justinbmeyer

jQuery 1.12 does not load in Zombie 2.5.1.

This is caused by:

support.createHTMLDocument = function () {
        if (!document.implementation.createHTMLDocument) {
            return false;
        }
        var doc = document.implementation.createHTMLDocument('');
        doc.body.innerHTML = '<form></form><form></form>';
        return doc.body.childNodes.length === 2;
    }();

The doc doesn't have a body, so innerHTML is set on undefined. The fix would be to make sure there's a body.

I'm not sure if #2154 indicates this was purposeful or not. We have a big matrix of tests for new and old versions of jQuery, along with build tools that need to work in a lot of different versions of node.

I wouldn't be able to use Zombie to verify CanJS + jQuery 1.12 in a node 0.12 environment. Yeah ... an odd situation. Please let me know what you think. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions