Deferred: Fix $.when with resolved deferred and progress callbacks

nicolashenry · markelog · commit efb98f85bab7 · 2014-12-25T15:48:57.000+03:00
Ref ab20d9d
diff --git a/src/deferred.js b/src/deferred.js
@@ -133,9 +133,9 @@ jQuery.extend({
 			for ( ; i < length; i++ ) {
 				if ( resolveValues[ i ] && jQuery.isFunction( resolveValues[ i ].promise ) ) {
 					resolveValues[ i ].promise()
+						.progress( updateFunc( i, progressContexts, progressValues ) )
 						.done( updateFunc( i, resolveContexts, resolveValues ) )
-						.fail( deferred.reject )
-						.progress( updateFunc( i, progressContexts, progressValues ) );
+						.fail( deferred.reject );
 				} else {
 					--remaining;
 				}
diff --git a/test/unit/deferred.js b/test/unit/deferred.js
@@ -436,3 +436,25 @@ test( "jQuery.when - joined", function() {
 	deferreds.futureSuccess.resolve( 1 );
 	deferreds.futureError.reject( 0 );
 });
+
+test( "jQuery.when - resolved", function() {
+
+	expect( 6 );
+
+	var a = jQuery.Deferred().notify( 1 ).resolve( 4 ),
+		b = jQuery.Deferred().notify( 2 ).resolve( 5 ),
+		c = jQuery.Deferred().notify( 3 ).resolve( 6 );
+
+	jQuery.when( a, b, c ).progress(function( a, b, c ) {
+		strictEqual( a, 1, "first notify value ok" );
+		strictEqual( b, 2, "second notify value ok" );
+		strictEqual( c, 3, "third notify value ok" );
+	}).done(function( a, b, c ) {
+		strictEqual( a, 4, "first resolve value ok" );
+		strictEqual( b, 5, "second resolve value ok" );
+		strictEqual( c, 6, "third resolve value ok" );
+	}).fail(function() {
+		ok( false, "Error on resolve" );
+	});
+
+});
