CSS: Drop the cache in finalPropName

mgol · mgol · commit d1ce9e664b3c · 2024-11-20T00:56:05.000+01:00
The `finalPropName` util caches properties detected to require a vendor prefix. This used to cache unprefixed properties as well, but it was reported that this logic broke accidentally during a refactor. Since fewer & fewer properties require a vendor prefix and caching a few basic checks likely has negligible perf benefits, opt to saving a few bytes and remove the cache. Ref gh-5582
diff --git a/src/css/finalPropName.js b/src/css/finalPropName.js
@@ -1,11 +1,13 @@
 import { document } from "../var/document.js";
 
 var cssPrefixes = [ "Webkit", "Moz", "ms" ],
-	emptyStyle = document.createElement( "div" ).style,
-	vendorProps = {};
+	emptyStyle = document.createElement( "div" ).style;
 
-// Return a vendor-prefixed property or undefined
-function vendorPropName( name ) {
+// Return a potentially-mapped vendor prefixed property
+export function finalPropName( name ) {
+	if ( name in emptyStyle ) {
+		return name;
+	}
 
 	// Check for vendor prefixed names
 	var capName = name[ 0 ].toUpperCase() + name.slice( 1 ),
@@ -17,17 +19,6 @@ function vendorPropName( name ) {
 			return name;
 		}
 	}
-}
 
-// Return a potentially-mapped vendor prefixed property
-export function finalPropName( name ) {
-	var final = vendorProps[ name ];
-
-	if ( final ) {
-		return final;
-	}
-	if ( name in emptyStyle ) {
-		return name;
-	}
-	return vendorProps[ name ] = vendorPropName( name ) || name;
+	return name;
 }
