Manipulation: simplify html wrappers

markelog · markelog · commit b744a50d4726 · 2015-02-11T00:46:12.000+03:00
Take advantage of html serialization for html wrappers - saves 26 bytes Plus add additional test for "col" element (cherry-picked from 0ea342a) Closes gh-2031 Fixes gh-2002
diff --git a/src/manipulation.js b/src/manipulation.js
@@ -52,9 +52,20 @@ var nodeNames = "abbr|article|aside|audio|bdi|canvas|data|datalist|" +
 		param: [ 1, "<object>", "</object>" ],
 
 		thead: [ 1, "<table>", "</table>" ],
-		tr: [ 2, "<table><tbody>", "</tbody></table>" ],
-		col: [ 2, "<table><tbody></tbody><colgroup>", "</colgroup></table>" ],
-		td: [ 3, "<table><tbody><tr>", "</tr></tbody></table>" ],
+
+		// Some of the following wrappers are not fully defined, because
+		// their parent elements (except for "table" element) could be omitted
+		// since browser parsers are smart enough to auto-insert them
+
+		// Support: Android 2.3
+		// Android browser doesn't auto-insert colgroup
+		col: [ 2, "<table><colgroup>", "</colgroup></table>" ],
+
+		// Auto-insert "tbody" element
+		tr: [ 2, "<table>", "</table>" ],
+
+		// Auto-insert "tbody" and "tr" elements
+		td: [ 3, "<table>", "</table>" ],
 
 		// IE8 can't serialize link, script, style, or any html5 (NoScope) tags,
 		// unless wrapped in a div with non-breaking characters in front of it.
diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
@@ -2485,6 +2485,18 @@ test( "Make sure jQuery.fn.remove can work on elements in documentFragment", 1,
 	equal( fragment.childNodes.length, 0, "div element was removed from documentFragment" );
 });
 
+test( "Make sure col element is appended correctly", function() {
+	expect( 1 );
+
+	var table = jQuery( "<table cellpadding='0'><tr><td style='padding:0'>test</td></tr></table>" );
+
+	jQuery( table ).appendTo( "#qunit-fixture" );
+
+	jQuery( "<col width='150'/>" ).prependTo( table );
+
+	strictEqual( table.find( "td" ).width(), 150 );
+});
+
 asyncTest( "Insert script with data-URI (gh-1887)", 1, function() {
 	Globals.register( "testFoo" );
 	Globals.register( "testSrcFoo" );
@@ -2509,4 +2521,3 @@ asyncTest( "Insert script with data-URI (gh-1887)", 1, function() {
 		start();
 	}, 100 );
 });
-
