Selector: Fix the Sizzle test for form#lengthtest

mgol · mgol · commit b4b10f34ba29 · 2022-09-12T15:48:42.000+02:00
Also, add a test to jQuery that will actually test for this issue.
diff --git a/src/selector.js b/src/selector.js
@@ -200,8 +200,9 @@ function find( selector, context, results, seed ) {
 								push.call( results, elem );
 								return results;
 							}
+						} else {
+							return results;
 						}
-						return results;
 
 					// Element context
 					} else {
diff --git a/test/unit/selector.js b/test/unit/selector.js
@@ -227,9 +227,9 @@ QUnit.test( "broken selectors throw", function( assert ) {
 } );
 
 QUnit.test( "id", function( assert ) {
-	assert.expect( 34 );
+	assert.expect( 35 );
 
-	var fiddle, a;
+	var fiddle, a, lengthtest;
 
 	assert.t( "ID Selector", "#body", [ "body" ] );
 	assert.t( "ID Selector w/ Element", "body#body", [ "body" ] );
@@ -288,6 +288,15 @@ QUnit.test( "id", function( assert ) {
 
 	assert.t( "ID Selector on Form with an input that has a name of 'id'", "#lengthtest", [ "lengthtest" ] );
 
+	// Run the above test again but with `jQuery.find` directly to avoid the jQuery
+	// quick path that avoids running the selector engine.
+	lengthtest = jQuery.find( "#lengthtest" );
+	assert.strictEqual(
+		lengthtest && lengthtest[ 0 ],
+		document.getElementById( "lengthtest" ),
+		"ID Selector on Form with an input that has a name of 'id' - no quick path (#lengthtest)"
+	);
+
 	assert.t( "ID selector with non-existent ancestor", "#asdfasdf #foobar", [] ); // bug trac-986
 
 	assert.deepEqual( jQuery.find( "div#form", document.body ), [],

Original file line number	Diff line number	Diff line change
`@@ -200,8 +200,9 @@ function find( selector, context, results, seed ) {`
`200`	`200`	`push.call( results, elem );`
`201`	`201`	`return results;`
`202`	`202`	`}`
	`203`	`+ } else {`
	`204`	`+ return results;`
`203`	`205`	`}`
`204`		`- return results;`
`205`	`206`
`206`	`207`	`// Element context`
`207`	`208`	`} else {`