Attributes: revert returning null for non-elements

timmywil · timmywil · commit a40365549195 · 2015-03-16T14:12:00.000-04:00
diff --git a/src/attributes/attr.js b/src/attributes/attr.js
@@ -31,7 +31,7 @@ jQuery.extend({
 
 		// don't get/set attributes on text, comment and attribute nodes
 		if ( !elem || nType === 3 || nType === 8 || nType === 2 ) {
-			return null;
+			return;
 		}
 
 		// Fallback to prop when attributes are not supported
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -371,7 +371,7 @@ test( "attr(String, Object)", function() {
 	jQuery.each( [ commentNode, textNode, attributeNode ], function( i, elem ) {
 		var $elem = jQuery( elem );
 		$elem.attr( "nonexisting", "foo" );
-		strictEqual( $elem.attr("nonexisting"), null, "attr(name, value) works correctly on comment and text nodes (bug #7500)." );
+		strictEqual( $elem.attr("nonexisting"), undefined, "attr(name, value) works correctly on comment and text nodes (bug #7500)." );
 	});
 
 	jQuery.each( [ window, document, obj, "#firstp" ], function( i, elem ) {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ jQuery.extend({`
`31`	`31`
`32`	`32`	`// don't get/set attributes on text, comment and attribute nodes`
`33`	`33`	`if ( !elem \|\| nType === 3 \|\| nType === 8 \|\| nType === 2 ) {`
`34`		`- return null;`
	`34`	`+ return;`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`// Fallback to prop when attributes are not supported`