Skip to content

Commit 9db6dd3

Browse files
committed
Build: Make sure all source modules' exports are used
To achieve that, use `eslint-plugin-import`'s `no-unused-modules` rule. Also, explicitly import `event/trigger.js` from `jquery.js`; so far it was only imported from ajax.js, making it mistakenly skipped in the `custom:slim,-deprecated` build.
1 parent 90fed4b commit 9db6dd3

File tree

7 files changed

+6
-10
lines changed

7 files changed

+6
-10
lines changed

src/.eslintrc.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@
1212

1313
"rules": {
1414
"import/extensions": [ "error", "always" ],
15-
"import/no-cycle": "error"
15+
"import/no-cycle": "error",
16+
"import/no-unused-modules": [ "error", {
17+
"unusedExports": true,
18+
"ignoreExports": [ "src/*.js" ]
19+
} ]
1620
},
1721

1822
"overrides": [

src/core/init.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,3 @@ init.prototype = jQuery.fn;
118118

119119
// Initialize central reference
120120
rootjQuery = jQuery( document );
121-
122-
export default init;

src/core/parseXML.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,3 @@ jQuery.parseXML = function( data ) {
2020
}
2121
return xml;
2222
};
23-
24-
export default jQuery.parseXML;

src/core/var/rhtml.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/event/trigger.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,5 +192,3 @@ jQuery.fn.extend( {
192192
}
193193
}
194194
} );
195-
196-
export default jQuery;

src/jquery.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import "./queue.js";
1111
import "./queue/delay.js";
1212
import "./attributes.js";
1313
import "./event.js";
14+
import "./event/trigger.js";
1415
import "./manipulation.js";
1516
import "./manipulation/_evalUrl.js";
1617
import "./wrap.js";

src/manipulation/_evalUrl.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,3 @@ jQuery._evalUrl = function( url, options, doc ) {
2222
}
2323
} );
2424
};
25-
26-
export default jQuery._evalUrl;

0 commit comments

Comments
 (0)