Revert "Event: remove guard for falsy handler argument of jQuery#on method"

timmywil · timmywil · commit 771600f8586a · 2016-01-07T13:59:47.000-05:00
This reverts commit fac67a9.
diff --git a/src/event.js b/src/event.js
@@ -74,6 +74,8 @@ function on( elem, types, selector, data, fn, one ) {
 	}
 	if ( fn === false ) {
 		fn = returnFalse;
+	} else if ( !fn ) {
+		return elem;
 	}
 
 	if ( one === 1 ) {
diff --git a/test/unit/event.js b/test/unit/event.js
@@ -5,8 +5,22 @@ QUnit.module( "event", {
 	teardown: moduleTeardown
 } );
 
-QUnit.test( "on() with non-null,defined data", function( assert ) {
+QUnit.test( "null or undefined handler", function( assert ) {
+	assert.expect( 2 );
+
+	// Supports Fixes bug #7229
+	try {
+		jQuery( "#firstp" ).on( "click", null );
+		ok( true, "Passing a null handler will not throw an exception" );
+	} catch ( e ) {}
 
+	try {
+		jQuery( "#firstp" ).on( "click", undefined );
+		ok( true, "Passing an undefined handler will not throw an exception" );
+	} catch ( e ) {}
+} );
+
+QUnit.test( "on() with non-null,defined data", function( assert ) {
 	assert.expect( 2 );
 
 	var handler = function( event, data ) {

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,8 @@ function on( elem, types, selector, data, fn, one ) {`
`74`	`74`	`}`
`75`	`75`	`if ( fn === false ) {`
`76`	`76`	`fn = returnFalse;`
	`77`	`+ } else if ( !fn ) {`
	`78`	`+ return elem;`
`77`	`79`	`}`
`78`	`80`
`79`	`81`	`if ( one === 1 ) {`