Build: fix tests in AMD mode

timmywil · timmywil · commit 57652eecd96e · 2014-12-10T10:18:59.000-05:00
diff --git a/build/tasks/build.js b/build/tasks/build.js
@@ -26,7 +26,7 @@ module.exports = function( grunt ) {
 			skipSemiColonInsertion: true,
 			wrap: {
 				startFile: "src/intro.js",
-				endFile: "src/outro.js"
+				endFile: [ "src/exports/global.js", "src/outro.js" ]
 			},
 			paths: {
 				sizzle: "../external/sizzle/dist/sizzle"
@@ -61,13 +61,10 @@ module.exports = function( grunt ) {
 
 		} else {
 
-			// Ignore jQuery's exports (the only necessary one)
-			if ( name !== "jquery" ) {
-				contents = contents
-					.replace( /\s*return\s+[^\}]+(\}\);[^\w\}]*)$/, "$1" )
-					// Multiple exports
-					.replace( /\s*exports\.\w+\s*=\s*\w+;/g, "" );
-			}
+			contents = contents
+				.replace( /\s*return\s+[^\}]+(\}\);[^\w\}]*)$/, "$1" )
+				// Multiple exports
+				.replace( /\s*exports\.\w+\s*=\s*\w+;/g, "" );
 
 			// Remove define wrappers, closure ends, and empty declarations
 			contents = contents
diff --git a/src/.jshintrc b/src/.jshintrc
@@ -21,7 +21,8 @@
 
 	"globals": {
 		"jQuery": true,
-		"define": true,
-		"module": true
+		"define": false,
+		"module": false,
+		"noGlobal": true
 	}
 }
diff --git a/src/exports/global.js b/src/exports/global.js
@@ -1,7 +1,3 @@
-define([
-	"../core"
-], function( jQuery ) {
-
 var
 	// Map over jQuery in case of overwrite
 	_jQuery = window.jQuery,
@@ -24,8 +20,6 @@ jQuery.noConflict = function( deep ) {
 // Expose jQuery and $ identifiers, even in
 // AMD (#7102#comment:10, https://github.com/jquery/jquery/pull/557)
 // and CommonJS for browser emulators (#13566)
-if ( typeof noGlobal === "undefined" ) {
+if ( !noGlobal ) {
 	window.jQuery = window.$ = jQuery;
 }
-
-});
diff --git a/src/jquery.js b/src/jquery.js
@@ -29,10 +29,9 @@ define([
 	"./offset",
 	"./dimensions",
 	"./deprecated",
-	"./exports/amd",
-	"./exports/global"
+	"./exports/amd"
 ], function( jQuery ) {
 
-return jQuery;
+return (window.jQuery = window.$ = jQuery);
 
 });
diff --git a/src/outro.js b/src/outro.js
@@ -1 +1,2 @@
+return jQuery;
 }));
diff --git a/test/data/testinit.js b/test/data/testinit.js
@@ -304,7 +304,9 @@ this.loadTests = function() {
 				/**
 				 * Run in noConflict mode
 				 */
-				jQuery.noConflict();
+				if ( jQuery.noConflict ) {
+					jQuery.noConflict();
+				}
 
 				// Load the TestSwarm listener if swarmURL is in the address.
 				if ( loadSwarm ) {
diff --git a/test/unit/core.js b/test/unit/core.js
@@ -226,24 +226,27 @@ test( "globalEval execution after script injection (#7862)", 1, function() {
 	ok( window.strictEvalTest - now < 500, "Code executed synchronously" );
 });
 
-test("noConflict", function() {
-	expect(7);
+// This is not run in AMD mode
+if ( jQuery.noConflict ) {
+	test("noConflict", function() {
+		expect(7);
 
-	var $$ = jQuery;
+		var $$ = jQuery;
 
-	strictEqual( jQuery, jQuery.noConflict(), "noConflict returned the jQuery object" );
-	strictEqual( window["jQuery"], $$, "Make sure jQuery wasn't touched." );
-	strictEqual( window["$"], original$, "Make sure $ was reverted." );
+		strictEqual( jQuery, jQuery.noConflict(), "noConflict returned the jQuery object" );
+		strictEqual( window["jQuery"], $$, "Make sure jQuery wasn't touched." );
+		strictEqual( window["$"], original$, "Make sure $ was reverted." );
 
-	jQuery = $ = $$;
+		jQuery = $ = $$;
 
-	strictEqual( jQuery.noConflict(true), $$, "noConflict returned the jQuery object" );
-	strictEqual( window["jQuery"], originaljQuery, "Make sure jQuery was reverted." );
-	strictEqual( window["$"], original$, "Make sure $ was reverted." );
-	ok( $$().pushStack([]), "Make sure that jQuery still works." );
+		strictEqual( jQuery.noConflict(true), $$, "noConflict returned the jQuery object" );
+		strictEqual( window["jQuery"], originaljQuery, "Make sure jQuery was reverted." );
+		strictEqual( window["$"], original$, "Make sure $ was reverted." );
+		ok( $$().pushStack([]), "Make sure that jQuery still works." );
 
-	window["jQuery"] = jQuery = $$;
-});
+		window["jQuery"] = jQuery = $$;
+	});
+}
 
 test("trim", function() {
 	expect(13);

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,8 @@`
`21`	`21`
`22`	`22`	`"globals": {`
`23`	`23`	`"jQuery": true,`
`24`		`- "define": true,`
`25`		`- "module": true`
	`24`	`+ "define": false,`
	`25`	`+ "module": false,`
	`26`	`+ "noGlobal": true`
`26`	`27`	`}`
`27`	`28`	`}`