Skip to content

Commit 4cc4e54

Browse files
danielhusargibson042
authored andcommitted
Core: Simplify and speed up .each
Closes gh-1510 (cherry picked from commit eeda11c)
1 parent aec41a5 commit 4cc4e54

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

src/core.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -301,25 +301,20 @@ jQuery.extend({
301301

302302
// args is for internal usage only
303303
each: function( obj, callback, args ) {
304-
var value,
305-
i = 0,
304+
var i = 0,
306305
length = obj.length,
307306
isArray = isArraylike( obj );
308307

309308
if ( args ) {
310309
if ( isArray ) {
311310
for ( ; i < length; i++ ) {
312-
value = callback.apply( obj[ i ], args );
313-
314-
if ( value === false ) {
311+
if ( callback.apply( obj[ i ], args ) === false ) {
315312
break;
316313
}
317314
}
318315
} else {
319316
for ( i in obj ) {
320-
value = callback.apply( obj[ i ], args );
321-
322-
if ( value === false ) {
317+
if ( callback.apply( obj[ i ], args ) === false ) {
323318
break;
324319
}
325320
}
@@ -329,17 +324,13 @@ jQuery.extend({
329324
} else {
330325
if ( isArray ) {
331326
for ( ; i < length; i++ ) {
332-
value = callback.call( obj[ i ], i, obj[ i ] );
333-
334-
if ( value === false ) {
327+
if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) {
335328
break;
336329
}
337330
}
338331
} else {
339332
for ( i in obj ) {
340-
value = callback.call( obj[ i ], i, obj[ i ] );
341-
342-
if ( value === false ) {
333+
if ( callback.call( obj[ i ], i, obj[ i ] ) === false ) {
343334
break;
344335
}
345336
}

0 commit comments

Comments
 (0)