Core:CSS:Event: simplification of native method signatures

markelog · markelog · commit 49bce4712447 · 2015-05-03T13:59:18.000+03:00
* Remove third argument from "addEventListener" * Remove third argument from "removeEventListener" * Remove second argument from "getComputedStyle" Ref gh-2047 Ref 85577a3
diff --git a/src/core/ready.js b/src/core/ready.js
@@ -68,8 +68,8 @@ jQuery.extend({
  */
 function detach() {
 	if ( document.addEventListener ) {
-		document.removeEventListener( "DOMContentLoaded", completed, false );
-		window.removeEventListener( "load", completed, false );
+		document.removeEventListener( "DOMContentLoaded", completed );
+		window.removeEventListener( "load", completed );
 
 	// Support: IE<9
 	} else {
@@ -110,10 +110,10 @@ jQuery.ready.promise = function( obj ) {
 		// Standards-based browsers support DOMContentLoaded
 		} else if ( document.addEventListener ) {
 			// Use the handy event callback
-			document.addEventListener( "DOMContentLoaded", completed, false );
+			document.addEventListener( "DOMContentLoaded", completed );
 
 			// A fallback to window.onload, that will always work
-			window.addEventListener( "load", completed, false );
+			window.addEventListener( "load", completed );
 
 		// Support: IE<9
 		// If IE event model is used
diff --git a/src/css/curCSS.js b/src/css/curCSS.js
@@ -16,10 +16,10 @@ if ( window.getComputedStyle ) {
 		// IE throws on elements created in popups
 		// FF meanwhile throws on frame elements through "defaultView.getComputedStyle"
 		if ( elem.ownerDocument.defaultView.opener ) {
-			return elem.ownerDocument.defaultView.getComputedStyle( elem, null );
+			return elem.ownerDocument.defaultView.getComputedStyle( elem );
 		}
 
-		return window.getComputedStyle( elem, null );
+		return window.getComputedStyle( elem );
 	};
 
 	curCSS = function( elem, name, computed ) {
diff --git a/src/css/support.js b/src/css/support.js
@@ -107,7 +107,7 @@ define([
 
 		// Check for getComputedStyle so that this code is not run in IE<9.
 		if ( window.getComputedStyle ) {
-			divStyle = window.getComputedStyle( div, null );
+			divStyle = window.getComputedStyle( div );
 			pixelPositionVal = ( divStyle || {} ).top !== "1%";
 			boxSizingReliableVal = ( divStyle || { height: "4px" } ).height === "4px";
 			pixelMarginRightVal = ( divStyle || { marginRight: "4px" } ).marginRight === "4px";
@@ -128,7 +128,7 @@ define([
 			div.style.width = "1px";
 
 			reliableMarginRightVal =
-				!parseFloat( ( window.getComputedStyle( contents, null ) || {} ).marginRight );
+				!parseFloat( ( window.getComputedStyle( contents ) || {} ).marginRight );
 
 			div.removeChild( contents );
 		}
diff --git a/src/event.js b/src/event.js
@@ -677,7 +677,7 @@ jQuery.removeEvent = document.removeEventListener ?
 
 		// This "if" is needed for plain objects
 		if ( elem.removeEventListener ) {
-			elem.removeEventListener( type, handle, false );
+			elem.removeEventListener( type, handle );
 		}
 	} :
 	function( elem, type, handle ) {

Original file line number	Diff line number	Diff line change
`@@ -677,7 +677,7 @@ jQuery.removeEvent = document.removeEventListener ?`
`677`	`677`
`678`	`678`	`// This "if" is needed for plain objects`
`679`	`679`	`if ( elem.removeEventListener ) {`
`680`		`- elem.removeEventListener( type, handle, false );`
	`680`	`+ elem.removeEventListener( type, handle );`
`681`	`681`	`}`
`682`	`682`	`} :`
`683`	`683`	`function( elem, type, handle ) {`