Selector: Make empty attribute selectors work in IE 11/Edge again

mgol · mgol · commit 2c81e75fac09 · 2019-10-14T20:35:23.000+02:00
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Assigning a temporary name attribute to the document root (& removing it afterwards) seems to resolve the issue. Interestingly, IE 10 & older don't seem to have the issue. Fixes gh-4435
diff --git a/src/selector.js b/src/selector.js
@@ -19,7 +19,21 @@ define( [
 "use strict";
 
 var preferredDoc = document,
-	matches = documentElement.matches || documentElement.msMatchesSelector;
+	matches = documentElement.matches || documentElement.msMatchesSelector,
+	docElemHasNameAttribute = documentElement.hasAttribute( "name" ),
+	docElemNameAttribute = documentElement.getAttribute( "name" );
+
+
+// Support: IE 11+, Edge 15 - 18+
+// IE 11/Edge don't find elements on a `[name='']` query in some cases.
+// Adding a temporary attribute to the document before the selection works
+// around the issue.
+documentElement.setAttribute( "name", "" );
+if ( docElemHasNameAttribute ) {
+	documentElement.setAttribute( "name", docElemNameAttribute );
+} else {
+	documentElement.removeAttribute( "name" );
+}
 
 ( function() {
 
diff --git a/test/data/qunit-fixture.html b/test/data/qunit-fixture.html
@@ -116,6 +116,11 @@
 	<input type="radio" name="R1" value="2" />
 	<input type="text" name="My Name" value="me" />
 	<input type="reset" name="reset" value="NO" />
+	<div class="empty-name-container">
+		<div id="empty-name-parent">
+			<input type="text" id="name-empty" name="" value="" />
+		</div>
+	</div>
 	<select name="S1">
 		<option value="abc">ABC</option>
 		<option value="abc">ABC</option>
diff --git a/test/data/qunit-fixture.js b/test/data/qunit-fixture.js
diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -1255,7 +1255,7 @@ QUnit.test( "addClass(Array)", function( assert ) {
 } );
 
 QUnit.test( "addClass(Function) with incoming value", function( assert ) {
-	assert.expect( 57 );
+	assert.expect( 59 );
 	var pass, i,
 		div = jQuery( "#qunit-fixture div" ),
 		old = div.map( function() {
@@ -1330,7 +1330,7 @@ QUnit.test( "removeClass(Array) - simple", function( assert ) {
 } );
 
 QUnit.test( "removeClass(Function) with incoming value", function( assert ) {
-	assert.expect( 57 );
+	assert.expect( 59 );
 
 	var $divs = jQuery( "#qunit-fixture div" ).addClass( "test" ), old = $divs.map( function() {
 		return jQuery( this ).attr( "class" );
diff --git a/test/unit/selector.js b/test/unit/selector.js
@@ -719,7 +719,7 @@ QUnit.test( "attributes - special characters", function( assert ) {
 } );
 
 QUnit.test( "attributes - others", function( assert ) {
-	assert.expect( 10 );
+	assert.expect( 14 );
 
 	var div = document.getElementById( "foo" );
 
@@ -749,6 +749,17 @@ QUnit.test( "attributes - others", function( assert ) {
 	assert.ok( !jQuery( "<input type='checkbox'/>" ).prop( "checked", true ).is( "[checked]" ),
 		"[checked] selects by attribute (negative)"
 	);
+
+	assert.t( "empty name", "[name='']", [ "name-empty" ] );
+	assert.t( "prefixed empty name", "#empty-name-parent [name='']", [ "name-empty" ] );
+
+	var emptyNameContainer = jQuery( ".empty-name-container" );
+	assert.deepEqual( emptyNameContainer.find( "[name='']" ).get(),
+		q( "name-empty" ),
+		"empty name with context" );
+	assert.deepEqual( emptyNameContainer.find( "#empty-name-parent [name='']" ).get(),
+		q( "name-empty" ),
+		"prefixed empty name with context" );
 } );
 
 QUnit.test( "pseudo - (parent|empty)", function( assert ) {
@@ -1258,7 +1269,7 @@ QUnit[ QUnit.jQuerySelectorsPos ? "test" : "skip" ]( "pseudo - position", functi
 
 	assert.t( "Check element position", "#qunit-fixture div div:eq(0)", [ "nothiddendivchild" ] );
 	assert.t( "Check element position", "#select1 option:eq(3)", [ "option1d" ] );
-	assert.t( "Check element position", "#qunit-fixture div div:eq(10)", [ "names-group" ] );
+	assert.t( "Check element position", "#qunit-fixture div div:eq(10)", [ "no-clone-exception" ] );
 	assert.t( "Check element position", "#qunit-fixture div div:first", [ "nothiddendivchild" ] );
 	assert.t( "Check element position", "#qunit-fixture div > div:first", [ "nothiddendivchild" ] );
 	assert.t( "Check element position", "#qunit-fixture div:first a:first", [ "yahoo" ] );
