Skip to content

Commit 05e54ce

Browse files
committed
Event: remove preDispatch hook & simplify "simulate" signature
Ref 3655c4e
1 parent e847574 commit 05e54ce

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

src/event.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -648,8 +648,8 @@ jQuery.event = {
648648
}
649649
},
650650

651-
// Piggyback on a donor event to simulate a different one
652-
simulate: function( type, elem, event, bubble ) {
651+
// Piggyback on a donor event to simulate a diff ne
652+
simulate: function( type, elem, event ) {
653653
var e = jQuery.extend(
654654
new jQuery.Event(),
655655
event,
@@ -666,11 +666,9 @@ jQuery.event = {
666666
// constancy with other events and for more focused logic
667667
}
668668
);
669-
if ( bubble ) {
670-
jQuery.event.trigger( e, null, elem );
671-
} else {
672-
jQuery.event.dispatch.call( elem, e );
673-
}
669+
670+
jQuery.event.trigger( e, null, elem );
671+
674672
if ( e.isDefaultPrevented() ) {
675673
event.preventDefault();
676674
}
@@ -866,7 +864,7 @@ if ( !support.submit ) {
866864
if ( event._submitBubble ) {
867865
delete event._submitBubble;
868866
if ( this.parentNode && !event.isTrigger ) {
869-
jQuery.event.simulate( "submit", this.parentNode, event, true );
867+
jQuery.event.simulate( "submit", this.parentNode, event );
870868
}
871869
}
872870
},
@@ -905,7 +903,7 @@ if ( !support.change ) {
905903
this._justChanged = false;
906904
}
907905
// Allow triggered, simulated change events (#11500)
908-
jQuery.event.simulate( "change", this, event, true );
906+
jQuery.event.simulate( "change", this, event );
909907
});
910908
}
911909
return false;
@@ -917,7 +915,7 @@ if ( !support.change ) {
917915
if ( rformElems.test( elem.nodeName ) && !jQuery._data( elem, "change" ) ) {
918916
jQuery.event.add( elem, "change._change", function( event ) {
919917
if ( this.parentNode && !event.isSimulated && !event.isTrigger ) {
920-
jQuery.event.simulate( "change", this.parentNode, event, true );
918+
jQuery.event.simulate( "change", this.parentNode, event );
921919
}
922920
});
923921
jQuery._data( elem, "change", true );
@@ -957,7 +955,7 @@ if ( !support.focusin ) {
957955

958956
// Attach a single capturing handler on the document while someone wants focusin/focusout
959957
var handler = function( event ) {
960-
jQuery.event.simulate( fix, event.target, jQuery.event.fix( event ), true );
958+
jQuery.event.simulate( fix, event.target, jQuery.event.fix( event ) );
961959
};
962960

963961
jQuery.event.special[ fix ] = {

0 commit comments

Comments
 (0)