Reference: Changed description for data-transition #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
👍 Ps. I kinda forgot how we handled branches for different API docs versions so I am not sure if this needs to be cherry picked into the 1-5 branch. I suppose we can do a rebase of that branch against master to make sure fixes like this one end up in the 1-5 branch. |
Member
Author
|
@jaspermdegroot Thanks. Yes I don't know either what is the status of 1-5 branch. Maybe @gabrielschulhof would know? |
Member
Author
|
Notes from the mobile meeting today: we will need to cherry-pick. I will land in master and liaise with @arschmitz for the cherry-picking. |
apsdehal
pushed a commit
that referenced
this pull request
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-381