Allow empty string for profile image URL - #22
Open
Syfaro wants to merge 2 commits into
Open
Conversation
jpopesculian
requested changes
Nov 29, 2022
jpopesculian
left a comment
jpopesculian
left a comment
Owner
There was a problem hiding this comment.
looks great! just a nitpick (:
Syfaro
force-pushed
the
allow-empty-url
branch
from
November 29, 2022 15:39
1901380 to
bf65b63
Compare
Contributor
Author
|
Making it generic was a good idea! And thanks for the pointer on where to put it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a weird issue and I'm not entirely sure this is the best way to solve it. Essentially, some users have a
profile_image_urlthat's an empty string, not null, and that obviously can't be deserialized to aurl::Url. This adds a custom function for deserializing that converts empty strings toNone, and continues to parse non-empty strings to aurl::Url. I've loaded tens of thousands of profiles with these changes and it seems to fix the issue.