Skip to content

Does not work for last name Ma #16

Open

Description

@barrett-vegas-com

Jack Ma is parsed as first name Jack and suffix MA, no last name.

Activity

  1. eljeffeg commented on Mar 15, 2018

    @eljeffeg
    Contributor

    Yeah, it's a suffix for Master of Arts. You could remove it from the suffixArray.

  2. eljeffeg commented on Mar 15, 2018

    @eljeffeg
    Contributor

    A check could be added that if the last name is empty but a suffix is found, maybe ignore the suffix assignment. Also could check to see if it's mixed case as normally it would be written as MA.

    Maybe something like this toward the end.

        if (suffix !== "" && lastName === "") {
            suffix = "";
            lastName = nameParts[numWords - 1];
        }
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions