Skip to content

Avoid a crash - #4

Merged
artyom-stv merged 6 commits into
masterfrom
feature/avoid-crash
Jul 29, 2024
Merged

artyom-stv merged 6 commits into
masterfrom
feature/avoid-crash

Conversation

@artyom-stv

Copy link
Copy Markdown
Contributor

Наблюдаются падения (пример) из-за того, что для какого-то узла не зарегистрирована фабрика LHDriver. Наверное, это нештатная ситуация (пока изучаю, что происходит в приложении). Но я решил превентивно подпереть это падение в Lighthouse.

@artyom-stv
artyom-stv requested a review from rkolchakov July 29, 2024 17:16
Comment thread Lighthouse/LHRouter.m
let error = [NSError lh_nonFatalErrorWithDescription:@"Driver for node %@ not provided", node.label];
self.nonFatalErrorHandler(error);
}
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] Предлагаю вместо отдельного if добавить ветвление else.

Comment thread Lighthouse/LHAssert.h Resolved
@artyom-stv
artyom-stv merged commit 8105f22 into master Jul 29, 2024
@artyom-stv
artyom-stv deleted the feature/avoid-crash branch July 29, 2024 20:16
@artyom-stv artyom-stv mentioned this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants