cleanup-jooby-rxjava#1171
Conversation
(cherry picked from commit aac2fdf)
| public void onCompleted() { | ||
| if (done.compareAndSet(false, true)) { | ||
| deferred.resolve((Object) null); | ||
| deferred.resolve(null); |
There was a problem hiding this comment.
Are you sure about this? Feel we need the cast to Object
There was a problem hiding this comment.
Hi, as the function "resolve" in Deferred is specified with "Object", it's the least significant variant anyway. "null" will be resolved to "Object". As long as there are no other overrides, this cast can be removed.
resolve(final Object value)
There was a problem hiding this comment.
BTW, does PowerMock have a problem with proxying URL Objects? All builds fail with a strange NotFoundException in AssetForwardTest...
There was a problem hiding this comment.
You're right about resolve(Object), please ignore my comment.
Are you on linux? I did see that error in Travis, still can't reproduce/fix it
There was a problem hiding this comment.
no problem :-) Happy to help!
Nope, I'm on macOS (so kinda posix yeah). I found this regarding the error:
maybe we just need to switch to the agent version? I'm not that deep into your testing (yet), but maybe this helps?
There was a problem hiding this comment.
btw: locally I can't reproduce this error neither. All tests (maven/console and IntelliJ) are fine.
2 participants
fixed minor code issues