Skip to content

Conversation

@larryonoff
Copy link
Contributor

This's strange but I'm trying to replicate the error that I and, but not able yet :)

@larryonoff
Copy link
Contributor Author

@johnxnguyen could you please check this PR and if it's fine make new release?

@johnxnguyen
Copy link
Owner

@larryonoff my apologies for the delayed responses, I've been a bit of sick leave recently and back to a busy work schedule so time has been scarce.

I'm not sure I fully understand the problem this PR is solving, could you give some more context please?

Also, travis has been acting up lately and not running tests so I need to fix that first. I'm considering switching to another CI provider.

@larryonoff
Copy link
Contributor Author

@johnxnguyen our team develops internal framework. Some of the packages use external dependencies like Down. The structure of our main app is: App imports InternalSDK.PackageX, InternalSDK.PackageX imports Down.

We started migration to SPM from Cococapods recently. But we had an error with Down: Missing required module 'libcmark'. No such module 'libcmark'.

This PR should fix it.

PS. Strange thing that I cannot reproduce the issue now using the tag 0.11.

@larryonoff
Copy link
Contributor Author

Cleaned the project, updated all dependencies. As result "Missing required module 'libcmark'" for the current tag 0.11

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.15%. Comparing base (3b07bb5) to head (9dd46e0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files          60       60           
  Lines        1063     1063           
=======================================
  Hits          969      969           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

verstaen added a commit to verstaen/Down that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants