Add live tests #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanste
reviewed
Jun 19, 2023
openai/tests/test_client.py
Outdated
| auth=OPENAI_API_KEY, | ||
| backend="openai" | ||
| ) | ||
| kwargs = {"client": client} |
Owner
There was a problem hiding this comment.
We are silently dropping any kwargs here. Is that intentional? If so, I'd explicitly pass in client to the wrapped f on the next line and not do a assign-new-value-to-kwargs-and-spread-that-in.
Collaborator
Author
There was a problem hiding this comment.
Simplified it. Didn't realize I could pass the values of parametrize to a fixture, but pytest lets you do it cleanly.
johanste
reviewed
Jun 19, 2023
johanste
reviewed
Jun 19, 2023
openai/tests/test_client.py
Outdated
| @pytest.mark.parametrize("api_type", API_TYPE) | ||
| @configure_client | ||
| def test_client_completion(api_type, **kwargs): | ||
| client = kwargs.pop("client") |
Owner
There was a problem hiding this comment.
Why not make client a keyword-only argument to the test
Collaborator
Author
There was a problem hiding this comment.
Was a workaround, but instead I just made client a fixture now 😆
johanste
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test real calls to the APIs through the client using azure and openai endpoints