Skip to content

Improve visibility of install problems #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeferner merged 3 commits into from
Oct 18, 2021
Merged

Improve visibility of install problems #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a5f1e7
Bump path-parse from 1.0.6 to 1.0.7
dependabot[bot] Aug 11, 2021
8f0952d
Fix error check for bad javalib directory
andyf0x Oct 16, 2021
88168d1
Exit with error if Java home can't be found
andyf0x Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions findJavaHome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require('find-java-home')(function(err, home){
if(err){
console.error("[node-java] "+err);
if (err || !home) {
if (!err) err = Error('Unable to determine Java home location');
process.exit(1);
}
process.stdout.write(home);
Expand Down
4 changes: 2 additions & 2 deletions find_java_libdir.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ main () {
fi
fi

if [[ -z "${lib_dir}" ]]; then
error "Can't find lib dir for ${os} ${target_arch}, java home: ${java_home}"
if [[ ! -d "${lib_dir}" ]]; then
error "Can't find lib dir '${lib_dir}' for ${os} ${target_arch}, java home: ${java_home}"
fi
echo "${lib_dir}"
}
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.