Use typed array when dojavaArrayToV8
#358
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
looks good to me, would you mind squashing your commits and I'll merge it in. |
map Array(java) to TypedArray(v8) change return type of util::newArrayBuffer() Fix length of TypedArray update a test for char array use ArrayBuffer correctly under v0.12.x Use original implementation under node v0.10/v0.12 workaround: check whether node support 'TypedArray' fix workaround
wsw0108
force-pushed
the
typed-array
branch
from
cff594c to
1368b0c
Compare
Contributor
Author
|
If this PR is going to be merged, then #357 will not needed |
Owner
|
manually merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase performance, when java method return large array of primitive types.
For now, the single way map are:
booleanof java ->Uint8Arrayof nodebyteof java ->Int8Arrayof nodecharof java ->Uint16Arrayof nodeshortof java ->Int16Arrayof nodeintof java ->Int32Arrayof nodefloatof java ->Float32Arrayof nodedoubleof java ->Float64Arrayof nodelongof java -> N/A