Skip to content

Conversation

@egandro
Copy link
Contributor

@egandro egandro commented Jun 6, 2016

No description provided.

@joeferner
Copy link
Owner

Small little fix can you reword without using the word "I"

@joeferner joeferner merged commit c94925a into joeferner:master Jun 6, 2016
@egandro
Copy link
Contributor Author

egandro commented Jun 6, 2016

would it be ok for you to make a 0.7.1 version and pubish to npm?

@joeferner
Copy link
Owner

done

@egandro
Copy link
Contributor Author

egandro commented Jun 6, 2016

Thx!

@egandro
Copy link
Contributor Author

egandro commented Jun 6, 2016

May I ask you a question. I might found an issue:

-- java code ---
package com.foo.bar

import com.foo.bar.Reader;
import com.foo.bar.DataReport;

public interface IReportListener {
public void onReported(Reader reader, DataReport rep);
}

-- node code ---
var myProxy = this.java.newProxy('com.foo.bar.IReportListener ', {
onReported: function (reader, report) {
console.log("onReported");;
}
});

reader.setReportListenerSync(myProxy);


The node code crashes when the reader calls the proxy.

Any idea why? This works fine with simple types like strings an numbers.

@joeferner
Copy link
Owner

I don't see why that shouldn't work.

@egandro
Copy link
Contributor Author

egandro commented Jun 6, 2016

yes ;) me neither - but look what happenes:

(sorry for the stupid formating of github - i copy pasted the error)

A fatal error has been detected by the Java Runtime Environment:

EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00007ff931c9f5fc, pid=9040, tid=0x0000000000002d4c

JRE version: Java(TM) SE Runtime Environment (8.0_92-b14) (build 1.8.0_92-b14)

Java VM: Java HotSpot(TM) 64-Bit Server VM (25.92-b14 mixed mode windows-amd64 compressed oops)

Problematic frame:

C [nodejavabridge_bindings.node+0xf5fc] Java_node_NodeDynamicProxyClass_callJs+0x3c

Failed to write core dump. Minidumps are not enabled by default on client versions of Windows

An error report file with more information is saved as:

C:\projects\foo\node\hs_err_pid9040.log

If you would like to submit a bug report, please visit:

http://bugreport.java.com/bugreport/crash.jsp

The crash happened outside the Java Virtual Machine in native code.

See problematic frame for where to report the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants