Clarifications to Promises implementation (mostly documentation). #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeferner
added a commit
that referenced
this pull request
Jan 15, 2015
Clarifications to Promises implementation (mostly documentation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joeferner This PR mostly changes documentation about Promises. One significant change is that I figured out how to make this implementation work with the popular promises library Q. I also discovered the bluebird now works with node 0.8 after all. This means all 5 libraries I have test with pass all 6 cases in our test matrix.
I also realized that since the three promisified methods of the java module are not promisified until onJvmCreated that they cannot be the first java method an application calls. For now, I just recommend calling another method such as java.import() first. I considered creating a public method java.finalizeInitialization(), which would call the internal method ensureJvm(), but it seemed more trouble than it was worth, at last at the moment.