Support for Promises/A+ #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of 'suffix'.
Joe, I implemented an onJvmCreated callback so I could do the promisification from javascript instead of C++. Let me know if you have reservations about this approach.
There is a latent bug when using OpenJDK6 that I discovered while working on this test. The bug has nothing to do with promises, as the same behavior happens on the master branch. See joeferner#186
Owner
|
Looks really good. I may hold off and play with it for a while before npm publishing a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joeferner
Joe, this PR replaces PR #181, and is now ready for merging subject to your review.
The one thing we might want to do is declare this an 'experimental' feature in the README.
In fact, I want to do more experimentation, but I think this is a useful checkpoint.